Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LakeFormation ReadOnlyAdmins #33189

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Add support for LakeFormation ReadOnlyAdmins #33189

merged 1 commit into from
Aug 25, 2023

Conversation

svanschie
Copy link
Contributor

Description

Add support for ReadOnlyAdmins in the aws_lakeformation_data_lake_settings (data) resources

Relations

Closes #33143

References

Output from Acceptance Testing

% make testacc PKG=lakeformation TESTS=TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins
--- PASS: TestAccLakeFormation_serial (106.77s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (53.75s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins (53.75s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource (53.02s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins (53.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	110.600s
% make testacc PKG=lakeformation TESTS=TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run='TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins'  -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins
--- PASS: TestAccLakeFormation_serial (57.30s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource (57.30s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins (57.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	61.118s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lakeformation Issues and PRs that pertain to the lakeformation service. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 25, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 25, 2023
@svanschie svanschie force-pushed the f-aws_lakeformation_data_lake_settings-readonlyadmins branch from e8d165f to dfee6fd Compare August 25, 2023 11:09
@svanschie svanschie marked this pull request as ready for review August 25, 2023 11:13
github-actions[bot]
github-actions bot reviewed Aug 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @svanschie 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 25, 2023
ewbankkit
ewbankkit approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLakeFormation_serial/DataLakeSettings' PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/DataLakeSettings -timeout 180m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins
--- PASS: TestAccLakeFormation_serial (227.47s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (150.82s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (39.77s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (37.33s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (37.78s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins (35.95s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource (76.64s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/basic (37.87s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins (38.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	233.460s

@ewbankkit
Copy link
Contributor

@svanschie Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e59ae0b into hashicorp:main Aug 25, 2023
60 checks passed
@github-actions github-actions bot added this to the v5.15.0 milestone Aug 25, 2023
@svanschie svanschie deleted the f-aws_lakeformation_data_lake_settings-readonlyadmins branch August 25, 2023 15:57
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This functionality has been released in v5.15.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lakeformation Issues and PRs that pertain to the lakeformation service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.15.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add ReadOnlyAdmins Argument to aws_lakeformation_data_lake_settings Resource and Data Source
2 participants
@svanschie @ewbankkit